Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][jdbc] Add keyUtil to handle special columns #1258

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

Paddy0523
Copy link
Contributor

…estoreColumn and splitPk

Purpose of this pull request

1.Separate the relationship between incrementColumn with RestoreColumn and splitPk
2.Use keyUtil to handle data conversion between incrementColumn/splitPk/restoreColumn and StartLocation/EndLocation/state

Which issue you fix

Fixes # (issue).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@Paddy0523 Paddy0523 added the feature-request this is a feature requests on the product label Sep 15, 2022
@FlechazoW
Copy link
Member

LGTM.

@FlechazoW FlechazoW merged commit 972f42f into DTStack:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request this is a feature requests on the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants