Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trino): change groupBy/orderBy/where expression to expressionCol #356

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

feat(trino): change groupBy/orderBy/where expression to expressionCol #356

wants to merge 1 commit into from

Conversation

LuckyFBB
Copy link
Collaborator

给 expression 增加 columnRef 的规则组合成为 expressionCol

在 groupBy/orderBy/where 后面更改成为 expressionCol，expressionCol 收集成为 column

该解法会将 groupBy 之后的内容都识别为一个 column

SELECT count(*) FROM customer GROUP BY sum() '|'> 40000

对于上述位置的光标，最后 wordRanges 为 ['sum', '(', ')', ' ']

@LuckyFBB LuckyFBB marked this pull request as draft September 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LuckyFBB