Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs 组件 renderPanel 属性支持回调入参类型定义 #39

Closed
mumiao opened this issue Feb 24, 2021 · 0 comments · Fixed by #58
Closed

Tabs 组件 renderPanel 属性支持回调入参类型定义 #39

mumiao opened this issue Feb 24, 2021 · 0 comments · Fixed by #58
Assignees
@mumiao
Labels
enhancement New feature or request related tab
Projects
Kanban
Milestone
0.9.0-alpha.1

Comments

@mumiao
Copy link
Collaborator

mumiao commented Feb 24, 2021 •
edited

Resolved #38

Description

image
持renderFunc 回调入参自定义类型, 避免重复声明render 函数

The interface of ITab:

 interface ITab<T, P> { 
   renderPanel: (item? P) => ReactNode,
   resetProps:  ...
}
@mumiao mumiao self-assigned this Feb 24, 2021
@mumiao mumiao added the enhancement New feature or request label Feb 24, 2021
@mumiao mumiao linked a pull request Feb 24, 2021 that will close this issue
Support add, remove and update Panel, builtin Output, Problems Panel #38
Merged
@mumiao mumiao added this to the 0.9.0-alpha.1 milestone Feb 24, 2021
@mumiao mumiao added this to To do in Kanban via automation Feb 24, 2021
@mumiao mumiao removed a link to a pull request Feb 24, 2021
Support add, remove and update Panel, builtin Output, Problems Panel #38
Merged
@mumiao mumiao moved this from To do to In progress in Kanban Feb 24, 2021
This was referenced Feb 25, 2021
Closed
Closed
mumiao added a commit that referenced this issue Feb 25, 2021
@mumiao
feat: closed #39
715db40
@mumiao mumiao linked a pull request Feb 25, 2021 that will close this issue
Refactor editorService editorTab interface / optimize Tab component #55
Closed
mumiao added a commit that referenced this issue Feb 26, 2021
@mumiao
feat: closed #39
2ddee17
mumiao added a commit that referenced this issue Feb 26, 2021
@mumiao
refactor: closed #39
c6694cd
mumiao added a commit that referenced this issue Feb 26, 2021
@mumiao
feat: closed #39
c8d4d90
@mumiao mumiao mentioned this issue Feb 26, 2021
Merged
@mumiao mumiao linked a pull request Feb 26, 2021 that will close this issue
Refactor editorService editorTab interface / optimize Tab component #58
Merged
Kanban automation moved this from In progress to Done Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mumiao mumiao

Labels
enhancement New feature or request related tab
Projects
Kanban
Done
Milestone
0.9.0-alpha.1
1 participant
@mumiao