Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Palette 集成 Theme 切换 #70

Closed
wewoor opened this issue Mar 3, 2021 · 1 comment · Fixed by #75
Closed

Command Palette 集成 Theme 切换 #70

wewoor opened this issue Mar 3, 2021 · 1 comment · Fixed by #75
Assignees
Labels
enhancement New feature or request
Projects

Comments

@wewoor
Copy link
Collaborator

wewoor commented Mar 3, 2021

No description provided.

@wewoor wewoor created this issue from a note in Kanban (To do) Mar 3, 2021
@wewoor wewoor self-assigned this Mar 3, 2021
@wewoor wewoor added the enhancement New feature or request label Mar 3, 2021
@wewoor
Copy link
Collaborator Author

wewoor commented Mar 3, 2021

实现 Theme Action, 参考:

vs/workbench/contrib/themes/browser/themes.contribution.ts

@wewoor wewoor moved this from To do to In progress in Kanban Mar 5, 2021
@wewoor wewoor moved this from In progress to Review in progress in Kanban Mar 9, 2021
@wewoor wewoor moved this from Review in progress to In progress in Kanban Mar 10, 2021
Kanban automation moved this from In progress to Done Mar 11, 2021
zhangtengjin pushed a commit that referenced this issue Mar 11, 2021
* feat(monaco-editor): override layoutService and quickAccessService

There encapusulated a monacoService, the default monaco-editor component will be created by it, and
also you can access ServiceCollection

* refactor: create the monacoInstance by monacoService

* feat: update IColorTheme and add enum type ColorScheme

* feat: add selectColorThemeAction

* feat: add monacoService

* feat: add getColorTheme method

* feat: add editorInstance public property

* feat(activitybar): open CommandPalette and ThemePalette in settings menu

re #16, re #70

* fix: remove monacoInstnace dispose action

* refactor: delcare the monacoService innerly

* test: mock canvas and monacoService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant