Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Top Bar Revamp #86

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Top Bar Revamp #86

merged 2 commits into from
Nov 3, 2023

Conversation

a-thansen
Copy link
Contributor

Progress Journal

24/10

image

Changed most containers to %, added Labelling, bigger screen format fix

Bugs:

  • Narrower browser window size causes container overlap and shrinkage:
    image

*not sure if its necessary to fix

TBA:

  • re-do drop down selectors to check box selectors
  • add hamburger button placeholder
  • add "Filters:" Label (low priority)

@a-thansen
Top Bar Revamp
64c9155 
Top Bar Revamp

Move all filters to top, reformatted containers, added labels

* TBF when browser narrow, date filters stack

Quick fix

Fixed calendar pop up width

more
@a-thansen a-thansen linked an issue Oct 24, 2023 that may be closed by this pull request
Move Dropdown Menu (Severity Condition ) #65
Closed
@a-thansen a-thansen added this to the Release 2 milestone Oct 24, 2023
@a-thansen a-thansen linked an issue Oct 24, 2023 that may be closed by this pull request
TopBar: Beautify #71
Closed
@a-thansen a-thansen added feature New feature or request frontend Frontend related Main map Features related to the main map page labels Oct 24, 2023
@a-thansen a-thansen self-assigned this Oct 24, 2023
@a-thansen a-thansen marked this pull request as draft October 24, 2023 14:31
@Seb-sti1 Seb-sti1 mentioned this pull request Oct 27, 2023
Closed
@a-thansen a-thansen marked this pull request as ready for review October 30, 2023 13:51
@a-thansen a-thansen requested review from Seb-sti1 and marcosantiagomuro and removed request for Seb-sti1 October 30, 2023 13:52
@marcosantiagomuro
Copy link
Contributor

looks great! I think there should be a way of avoiding the bug when the window gets smaller.

WhatsApp Image 2023-10-31 at 08 45 28

because there would be the space to put it there, I think

second is it possible to make the dropdown menus a bit wider?
WhatsApp Image 2023-10-31 at 08 45 39

the parameters that have "long" names get cropped out.

but looks solid! nice :)

marcosantiagomuro
marcosantiagomuro reviewed Oct 31, 2023
View reviewed changes
frontend/src/css/navbar.css Outdated Show resolved Hide resolved
frontend/src/css/navbar.css Show resolved Hide resolved
frontend/src/css/navbar.css Outdated Show resolved Hide resolved
@a-thansen
Copy link
Contributor Author

@marcosantiagomuro Fixed the bugs, now it looks like this:
image
With the addition of burger button, and upload data button, there might not be enough space ->> maybe consider a show/hide filters button when window reaches a certain size? (for release 3)

@a-thansen a-thansen linked an issue Oct 31, 2023 that may be closed by this pull request
Search bar improvement #52
Closed
3 tasks
Seb-sti1
Seb-sti1 reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash before merging?

frontend/src/Components/Map/Inputs/Search.tsx Outdated Show resolved Hide resolved
frontend/src/Components/Map/Inputs/MultiSelector.tsx Outdated Show resolved Hide resolved
@a-thansen a-thansen force-pushed the 71-topbar-beautify branch 3 times, most recently from e4ea834 to 668d7b2 Compare November 1, 2023 15:21
@a-thansen
Copy link
Contributor Author

So I couldn't squash into one singular commit, because I ended up doing some merging... Hope it won't be a problem. @Seb-sti1

@a-thansen a-thansen added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 3, 2023
@a-thansen a-thansen added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 3, 2023
@a-thansen a-thansen added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 3, 2023
@a-thansen
Copy link
Contributor Author

image

@a-thansen a-thansen added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 3, 2023
@a-thansen a-thansen added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 3, 2023
@a-thansen a-thansen added this pull request to the merge queue Nov 3, 2023
Merged via the queue into dev with commit e77bbc6 Nov 3, 2023
4 checks passed
@Seb-sti1 Seb-sti1 deleted the 71-topbar-beautify branch November 4, 2023 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcosantiagomuro marcosantiagomuro marcosantiagomuro left review comments

@Seb-sti1 Seb-sti1 Seb-sti1 approved these changes

Assignees

@a-thansen a-thansen

Labels
feature New feature or request frontend Frontend related Main map Features related to the main map page
Projects
None yet
Milestone
Release 2
Development

Successfully merging this pull request may close these issues.

TopBar: Beautify Move Dropdown Menu (Severity Condition ) Search bar improvement
3 participants
@a-thansen @marcosantiagomuro @Seb-sti1