Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensively rename classes, etc., in OKS-related code #376

Closed
jcfreeman2 opened this issue Jun 13, 2024 · 4 comments
Closed

Extensively rename classes, etc., in OKS-related code #376

jcfreeman2 opened this issue Jun 13, 2024 · 4 comments

Comments

@jcfreeman2
Copy link
Collaborator

...as mentioned at this morning's OKS meeting. The name changes are detailed here:
https://docs.google.com/spreadsheets/d/1k3ScIDQJTLHPjsMgsIPm8tGYSZa6HEm5f1xvsl8M5vU/edit?gid=0#gid=0

jcfreeman2 pushed a commit that referenced this issue Jun 14, 2024
jcfreeman2 pushed a commit that referenced this issue Jun 14, 2024
jcfreeman2 pushed a commit that referenced this issue Jun 14, 2024
jcfreeman2 added a commit to DUNE-DAQ/appfwk that referenced this issue Jun 14, 2024
…6_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/appmodel that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/confmodel that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/daqsystemtest that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/integrationtest that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/oksconfgen that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/readoutlibs that referenced this issue Jun 14, 2024
…6_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/readoutmodules that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/timinglibs that referenced this issue Jun 14, 2024
…6_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/trgtools that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/trigger that referenced this issue Jun 14, 2024
…6_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
jcfreeman2 added a commit to DUNE-DAQ/triggeralgs that referenced this issue Jun 14, 2024
…_renames_for_v5

JCF: update names as described in DUNE-DAQ/daq-release#376 and detail…
@jcfreeman2
Copy link
Collaborator Author

A first round of merges was performed on Friday. Saturday on Slack Alessandro pointed out that the following changes were still needed:

  • DataReceiverModule needs to be changed to DataReaderModule
  • DPDKReader to DPDKReaderModule (I believe he's already done this)
  • FDFakeCardReader to FDFakeCardReaderModule

jcfreeman2 pushed a commit to DUNE-DAQ/fdreadoutmodules that referenced this issue Jun 17, 2024
jcfreeman2 pushed a commit to DUNE-DAQ/integrationtest that referenced this issue Jun 17, 2024
jcfreeman2 pushed a commit to DUNE-DAQ/readoutmodules that referenced this issue Jun 17, 2024
jcfreeman2 pushed a commit that referenced this issue Jun 17, 2024
jcfreeman2 pushed a commit that referenced this issue Jun 17, 2024
…FakeReaderModule as Giovanna and Alessandro mentioned on Slack a little while ago
@jcfreeman2
Copy link
Collaborator Author

Further renames for today:

  • WIBConfigurator -> WIBModule
  • DataReceiverModule -> DataReaderModule, DataReceiverConf -> DataReaderConf

For the latter case, changes that made it onto the develop branch of appmodel overnight meant that DataReceiverModule persisted despite this morning's merge of johnfreeman/daq-release_issue376_renames_for_v5_pt2

jcfreeman2 pushed a commit that referenced this issue Jun 18, 2024
…ts.sh (see today's comment in the Issue)
jcfreeman2 pushed a commit to DUNE-DAQ/appmodel that referenced this issue Jun 18, 2024
jcfreeman2 pushed a commit that referenced this issue Jun 18, 2024
…e WIBConfigurator being renamed WIBModule
jcfreeman2 pushed a commit to DUNE-DAQ/wibmod that referenced this issue Jun 18, 2024
jcfreeman2 added a commit to DUNE-DAQ/wibmod that referenced this issue Jun 18, 2024
…_renames_for_v5_pt3

JCF: change names as per today's comment in DUNE-DAQ/daq-release#376
@jcfreeman2
Copy link
Collaborator Author

Closing this; three waves of name changes have been successfully performed and further changes are addressed in later issues (e.g., #379)

@jcfreeman2
Copy link
Collaborator Author

Complete; changes going in to fddaq-v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant