Making some changes to do with daq-kube #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiagoTAlves
changed the title
|
So far I have added some directories that get created with to the .gitignore file. Also when committing some changes to daq-kube, realised that daq-kube was being cloned by https not ssh. (Not sure if this was intentional or not) |
|
After speaking to @plasorak he said that cloning using https was intentional and so I changed it back |
jcpunk
reviewed
Nov 15, 2023
|
Can you squash down to one commit?
…On Wed, Nov 15, 2023, 11:45 AM Tiago Alves ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .makefile/daq-kube.mk
<#116 (comment)>:
> @@ -1,3 +1,3 @@
${MAKEFILE_DIR}/daq-kube/.kluctl.yaml:
@echo "Fetching daq-kube repo..."
- @cd ${MAKEFILE_DIR} && git clone https://github.com/DUNE-DAQ/daq-kube.git --recursive
+ @cd ${MAKEFILE_DIR} && git clone https://github.com/DUNE-DAQ/daq-kube.git --recursive
The space was a mistake after changing back from ***@***.*** Back to
https... I have now removed the space
—
Reply to this email directly, view it on GitHub
<#116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2673TYA3R7QU7DIEJ3PE3YET5SPAVCNFSM6AAAAAA7CZPVVGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZSGYYDKNJSHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.