Feature/does pr practice #166

adelkahomolova · 2019-11-20T16:12:54Z

Implement Does Pull Request Practice

…defined),

fix: interface of TestPracticeContext

fix: add return type

…e of PR minus 30 days

fix: define branch - master

codecov-io · 2019-11-20T16:28:52Z

Codecov Report

❗ No coverage uploaded for pull request base (master@bcae6be). Click here to learn what that means.
The diff coverage is 97.91%.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage          ?   87.84%           
=========================================
  Files             ?      139           
  Lines             ?     2920           
  Branches          ?      434           
=========================================
  Hits              ?     2565           
  Misses            ?      355           
  Partials          ?        0

Impacted Files	Coverage Δ
...projectComponent/projectComponentContextBinding.ts	`100% <ø> (ø)`
src/services/git/IVCSService.ts	`100% <ø> (ø)`
src/inspectors/ICollaborationInspector.ts	`100% <ø> (ø)`
...bServiceMockFolder/getPullsServiceResponse.mock.ts	`100% <ø> (ø)`
...ubServiceMockFolder/getRepoCommitsResponse.mock.ts	`100% <ø> (ø)`
...nguageIndependent/CorrectCommitMessagesPractice.ts	`100% <100%> (ø)`
src/contexts/language/languageContextBinding.ts	`86.88% <100%> (ø)`
...ceMockFolder/getRepoCommitsServiceResponse.mock.ts	`100% <100%> (ø)`
src/services/bitbucket/BitbucketService.ts	`76.11% <100%> (ø)`
src/practices/index.ts	`100% <100%> (ø)`
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcae6be...c8c3a57. Read the comment docs.

src/inversify.config.ts

src/practices/LanguageIndependent/DoesPullRequests.spec.ts

src/practices/LanguageIndependent/DoesPullRequests.ts

test/helpers/gitHubNock.ts

src/services/git/__MOCKS__/gitHubServiceMockFolder/getPullServiceResponse.mock.ts

src/services/git/__MOCKS__/gitHubServiceMockFolder/getPullsServiceResponse.mock.ts

src/practices/LanguageIndependent/DoesPullRequests.ts

…feature/does-PR-practice # Conflicts: # package.json

…s/dx-scanner into feature/correct-commit-message-practice # Conflicts: # package.json

…feature/correct-commit-message-practice # Conflicts: # package.json # src/inspectors/ICollaborationInspector.ts # src/model.ts # src/services/git/GitHubService.spec.ts

…feature/correct-commit-message-practice

…feature/does-PR-practice # Conflicts: # package.json # src/inspectors/ICollaborationInspector.ts # src/model.ts # src/services/git/GitHubService.spec.ts

…feature/does-PR-practice

…s/dx-scanner into feature/correct-commit-message-practice # Conflicts: # package.json

src/services/git/GitHubService.ts

…s/dx-scanner into feature/correct-commit-message-practice

prokopsimek

🎉🎉🎉

# Conflicts: # .vscode/settings.json # src/inversify.config.ts # src/services/git/GitHubService.spec.ts

…essage-practice # Conflicts: # types/gradle-to-js/parse-commit-message.ts

…practice Feature/correct commit message practice

prokopsimek · 2019-12-06T17:40:01Z

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

adelkahomolova added 16 commits November 20, 2019 11:23

fix: return CollaborationInspector and IssueTrackingInspector (not un…

d461ad7

…defined),

fix: bind CollaborationInspector and IssueTrackingInspector,

b23c983

fix: interface of TestPracticeContext

fix: add BitbucketService to the type

7a71226

fix: remove comma

cf555bf

feat: add new practice

70e796a

WIP: implement Does PullRequest practice

f6bc1c2

fix: return repoCommits in own interface

63fe746

feat: add getRepoCommits into CollaborationInspector

dccf3eb

fix: add getRepoCommits() into interface,

648f066

fix: add return type

feat: Detect parcticing/notPracticing based on date of commit and dat…

1948193

…e of PR minus 30 days

fix: condition,

4213929

fix: define branch - master

fix: remove ambiguous binding

005b88b

WIP: testing

ccb1d70

fix: getRepoCommits() test

7ff57d6

fix: remove unnecessary name of branch

9473353

test: add test for DoesPR practice

fb2e323

adelkahomolova requested a review from prokopsimek as a code owner November 20, 2019 16:12

adelkahomolova self-assigned this Nov 20, 2019

adelkahomolova changed the title ~~Feature/does pr practice~~ [WIP] Feature/does pr practice Nov 20, 2019

adelkahomolova added 8 commits November 21, 2019 10:29

fix: use moment.js to convert days to milliseconds

99585fe

fix: change date of PR so it can for testing practicing Does PR practice

69932c3

test: add test for notPracticing practice

05c2107

fix: add condition so it doesn't fail if there are no PRs

4839367

fix: move getPathOrRepoUrl from ReporterUtils to GitServiceUtils

2198384

fix: change dates

8f9d5c1

refactor: use method instead of duplicating code

d22e8e5

fix: remove unnecessary condition

e0a43f5

adelkahomolova changed the title ~~[WIP] Feature/does pr practice~~ Feature/does pr practice Nov 21, 2019

prokopsimek requested changes Nov 21, 2019

View reviewed changes

adelkahomolova added 14 commits December 2, 2019 14:58

fix: unify name

c5bde88

fix: rename files

3769e64

fix: add moment to package.json

20fec03

fix: Add parse-commit-message

d5c6a08

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

1295de9

…feature/does-PR-practice # Conflicts: # package.json

Merge branch 'feature/does-PR-practice' of https://github.com/DXHeroe…

28a5cd7

…s/dx-scanner into feature/correct-commit-message-practice # Conflicts: # package.json

fix: remove merge conflict

dd8216d

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

3cfdc7a

…feature/correct-commit-message-practice # Conflicts: # package.json # src/inspectors/ICollaborationInspector.ts # src/model.ts # src/services/git/GitHubService.spec.ts

fix: add yarnrc to ignore engines

71421c1

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

bf9965d

…feature/correct-commit-message-practice

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

17b678d

…feature/does-PR-practice # Conflicts: # package.json # src/inspectors/ICollaborationInspector.ts # src/model.ts # src/services/git/GitHubService.spec.ts

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

0903e0f

…feature/does-PR-practice

fix: get all pullRequests

7bbca3b

fix: add queryState to new GitHubNock()

46a7a31

adelkahomolova changed the title ~~[WIP] Feature/does pr practice~~ Feature/does pr practice Dec 6, 2019

adelkahomolova requested a review from prokopsimek December 6, 2019 14:37

Merge branch 'feature/does-PR-practice' of https://github.com/DXHeroe…

a7a50d6

…s/dx-scanner into feature/correct-commit-message-practice # Conflicts: # package.json

prokopsimek requested changes Dec 6, 2019

View reviewed changes

src/services/git/GitHubService.ts Outdated Show resolved Hide resolved

adelkahomolova added 2 commits December 6, 2019 15:56

fix: use qs

e324c1f

Merge branch 'feature/does-PR-practice' of https://github.com/DXHeroe…

bf18140

…s/dx-scanner into feature/correct-commit-message-practice

prokopsimek self-requested a review December 6, 2019 15:12

prokopsimek approved these changes Dec 6, 2019

View reviewed changes

adelkahomolova and others added 4 commits December 6, 2019 17:22

fix: use method to change the message of the repo commits

bbf2136

Merge branch 'master' into feature/does-PR-practice

fe28929

# Conflicts: # .vscode/settings.json # src/inversify.config.ts # src/services/git/GitHubService.spec.ts

Merge branch 'feature/does-PR-practice' into feature/correct-commit-m…

aaf48da

…essage-practice # Conflicts: # types/gradle-to-js/parse-commit-message.ts

Merge pull request #171 from DXHeroes/feature/correct-commit-message-…

c8c3a57

…practice Feature/correct commit message practice

prokopsimek merged commit 789fb2a into master Dec 6, 2019

prokopsimek deleted the feature/does-PR-practice branch December 6, 2019 17:20

prokopsimek added the released label Dec 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/does pr practice #166

Feature/does pr practice #166

adelkahomolova commented Nov 20, 2019

codecov-io commented Nov 20, 2019 •

edited

Loading

prokopsimek left a comment

prokopsimek commented Dec 6, 2019

Feature/does pr practice #166

Feature/does pr practice #166

Conversation

adelkahomolova commented Nov 20, 2019

codecov-io commented Nov 20, 2019 • edited Loading

Codecov Report

prokopsimek left a comment

Choose a reason for hiding this comment

prokopsimek commented Dec 6, 2019

codecov-io commented Nov 20, 2019 •

edited

Loading