Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposals filter #245

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

MiltonTulli
Copy link
Member

Description

Fix ProposalCardWrapper filters and improve filter hook types.

Closes #205

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@MiltonTulli MiltonTulli changed the title fix proposalcardWrapper filters && add types to hook Fix proposals filter Aug 25, 2022
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 15f4cbe

😎 Browse the preview: https://bafybeiazdqkmkauospna7ymfc2kqlu7t6zqj2rthfogqnquale3sghdk7i.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeifootrxmbst5vzgljxn5n33hzmm57bf5ouz2awukcgsnigwnwfbla.ipfs.cf-ipfs.com

@Filipv95
Copy link
Contributor

Hey @MiltonTulli, I've check this PR, looks good to me, filters work as expected.

@MiltonTulli MiltonTulli merged commit 3306521 into DXgovernance:develop Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWPRGuild - 'Action' filters are not working as expected
3 participants