Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VotingPowerForProposalExecution #351

Merged
merged 6 commits into from
Sep 30, 2022
Merged

Fix VotingPowerForProposalExecution #351

merged 6 commits into from
Sep 30, 2022

Conversation

MiltonTulli
Copy link
Member

@MiltonTulli MiltonTulli commented Sep 27, 2022 •
edited
Loading

Description

  • Create new useVotingPowerForProposalExecution hook to return data according to guild type.
  • Remove getVotingPowerForProposalExecution wagmi call from inside useGuildConfig hook and include data from new useVotingPowerForProposalExecution hook.
  • Make swpr guild SnapshotERC20Guild

Closes #330

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: d79ca84

😎 Browse the preview: https://bafybeibahhaoz5iv3wqbkeitwvxpxgtvphytlaoz3x63h3wfqmqnxuftmq.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeibaswfrlqtuhfx4ewrn2m7bmdh5u6o3a3cdicryemcimenqex7h4y.ipfs.cf-ipfs.com

@MiltonTulli MiltonTulli requested review from a team and rossneilson September 27, 2022 18:59
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 2903ad6

😎 Browse the preview: https://bafybeicxj7yppmafzj2denxeqxfyde7d4ffznywgbckaaejhlwxn3u7dby.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeie7zn5brlv43yw3r62zsgfmf67h4iw7wjejrjnmx6oua5qh2wmzdi.ipfs.cf-ipfs.com

@dcrescimbeni
Copy link
Contributor

Looks good 👍

dcrescimbeni
dcrescimbeni previously approved these changes Sep 28, 2022
View reviewed changes
0xvangrim
0xvangrim reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@0xvangrim 0xvangrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this implementation! 🌟 Just a few comments. Also wondering a bit if you think your validation would help us with null values in the other hooks?

src/Modules/Guilds/Hooks/useVotingPowerForProposalExecution.ts Outdated Show resolved Hide resolved
src/Modules/Guilds/Hooks/useVotingPowerForProposalExecution.ts Outdated
args: [_proposalId],
};
// Validate args to avoid null values
if (isRepGuild && isSnapshotGuild && !!_proposalId) return snapshotRepConf;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 I wonder if we could add this to the other hooks as well to avoid having null

Copy link
Member Author

@MiltonTulli MiltonTulli Sep 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following. What are "this" and "other hooks"? Not sure what hooks are you referring to. Particularly this hook can have a fallback, but not sure about all of them.

src/Modules/Guilds/Hooks/useVotingPowerForProposalExecution.ts Show resolved Hide resolved
@rossneilson
Copy link
Contributor

Playing around with this, all quorum percentages and values look great, amazing work!

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeihhl4xx2pyjfgx2fbhg4ttmbawrevlbiw5ja7rqek44dtm2cl7s2i.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 33dded6

😎 Browse the preview: https://bafybeied36qlwxuhoemilhgiohjmgo67q6bgtxdh6uool2tonpkxzgtczq.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 147cb72

😎 Browse the preview: https://bafybeig4jt3cxuwdrzwrehbj4d3yggd7jp6buztlwoyirrikkk7keykpsm.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeiez4sq6nupzlehlckbnx34gz3o7ftv63k5alvml2ojxwgihlknnf4.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 2f29a01

😎 Browse the preview: https://bafybeigrnnui4tm57odzjhqqrm5d4yzswanseivtjdlqipxuqow4qvsnzi.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeicq3srdstir2xofchuxjdru2h7zr3uldg2f3jby5jsnawhumgdkla.ipfs.cf-ipfs.com

@dcrescimbeni dcrescimbeni merged commit de661cd into DXgovernance:develop Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xvangrim 0xvangrim 0xvangrim approved these changes

@dcrescimbeni dcrescimbeni dcrescimbeni left review comments

@rossneilson rossneilson Awaiting requested review from rossneilson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quorum snapshot bug
4 participants
@MiltonTulli @dcrescimbeni @rossneilson @0xvangrim