Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contribution reward periods #223

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Fix contribution reward periods #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
497bc14
fix(contracts/daostack): force ContributionReward scheme to use only …
AugustoL Oct 23, 2022
29bc4b7
test(daostack): test ContributionReward only use one period of time 0
AugustoL Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions contracts/daostack/universalSchemes/ContributionReward.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,33 +438,7 @@ contract ContributionReward is UniversalScheme, VotingMachineCallbacks, Proposal
* rewards[4] - Number of periods
*/
function validateProposalParams(int256 _reputationChange, uint256[5] memory _rewards) private pure {
require(((_rewards[3] > 0) || (_rewards[4] == 1)), "periodLength equal 0 require numberOfPeriods to be 1");
if (_rewards[4] > 0) {
// This is the only case of overflow not detected by the check below
require(
!(int256(_rewards[4]) == -1 && _reputationChange == (-2**255)),
"numberOfPeriods * _reputationChange will overflow"
);
//check that numberOfPeriods * _reputationChange will not overflow
require(
(int256(_rewards[4]) * _reputationChange) / int256(_rewards[4]) == _reputationChange,
"numberOfPeriods * reputationChange will overflow"
);
//check that numberOfPeriods * tokenReward will not overflow
require(
(_rewards[4] * _rewards[0]) / _rewards[4] == _rewards[0],
"numberOfPeriods * tokenReward will overflow"
);
//check that numberOfPeriods * ethReward will not overflow
require(
(_rewards[4] * _rewards[1]) / _rewards[4] == _rewards[1],
"numberOfPeriods * ethReward will overflow"
);
//check that numberOfPeriods * texternalTokenReward will not overflow
require(
(_rewards[4] * _rewards[2]) / _rewards[4] == _rewards[2],
"numberOfPeriods * texternalTokenReward will overflow"
);
}
require(_rewards[3] == 0, "periodLength should be 0");
require(_rewards[4] == 1, "numberOfPeriods should be 1");
}
}
Loading