Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ActionsModal refactor #896

Merged

Conversation

MiltonTulli
Copy link
Member

@MiltonTulli MiltonTulli commented May 24, 2022

Description

ActionsModal refactor

  • file/folder structure
  • translation
  • Basic snapshot test.

Closes #848

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@MiltonTulli MiltonTulli marked this pull request as draft May 24, 2022 17:09
@MiltonTulli MiltonTulli force-pushed the feature/actions-modal-refactor branch from 889f850 to e1ccb50 Compare May 24, 2022 17:11
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 13f5ea1

😎 Browse the preview: https://bafybeifgecfcakmxr32k7cldyiyzlkooacsjrflr2upmqulxvhd7yvmujy.ipfs.dweb.link

@MiltonTulli MiltonTulli marked this pull request as ready for review May 24, 2022 19:36
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 43ed33b

😎 Browse the preview: https://bafybeifgecfcakmxr32k7cldyiyzlkooacsjrflr2upmqulxvhd7yvmujy.ipfs.dweb.link

@MiltonTulli MiltonTulli requested a review from a team May 25, 2022 15:41
@MiltonTulli MiltonTulli merged commit 4d2236f into DXgovernance:v1.1-beta May 25, 2022
@@ -30,13 +30,5 @@
"features": [
"ENFORCED_BINARY"
]
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this back in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated by scripts/updateDeployedBytecodes after each yarn install. Something must change in dxdao contracts for this to be removed. The reason must be that script couldn't find the json inside artifacts.

@rossneilson
Copy link
Collaborator

I get why we have this, its nice for imports, but we should decide if we are making this standard and then we can use it everywhere.
Also I am not sure we need that extra components folder in ActionModal folder, we can just have folders for the individual components to make it flatter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants