-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ActionsModal refactor #896
Feature/ActionsModal refactor #896
Conversation
889f850
to
e1ccb50
Compare
✔️ Preview deployment is ready! 🔨 Explore the source changes: 13f5ea1 😎 Browse the preview: https://bafybeifgecfcakmxr32k7cldyiyzlkooacsjrflr2upmqulxvhd7yvmujy.ipfs.dweb.link |
✔️ Preview deployment is ready! 🔨 Explore the source changes: 43ed33b 😎 Browse the preview: https://bafybeifgecfcakmxr32k7cldyiyzlkooacsjrflr2upmqulxvhd7yvmujy.ipfs.dweb.link |
@@ -30,13 +30,5 @@ | |||
"features": [ | |||
"ENFORCED_BINARY" | |||
] | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated by scripts/updateDeployedBytecodes after each yarn install. Something must change in dxdao contracts for this to be removed. The reason must be that script couldn't find the json inside artifacts.
I get why we have this, its nice for imports, but we should decide if we are making this standard and then we can use it everywhere. |
Description
ActionsModal refactor
Closes #848
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: