Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests
DebugPlugin tests run with graftt agent; maven downloads it and puts the agent under
target/
- tests will only work from within the idea ifmvn test
(or later) has run once, as intellij doesn't care much about maven plugins and their behavior - but it does pick up the agent args from maven.running as a user
As a user, the crux here is that the JVM must start with
-javaagent:<graft-agent.jar>
. Maybe we should provide a script or something to automatically download the most recent agent?In the tests, it's solved by relying on maven plugins. I guess something similar could be done for gradle.
other stuff
new module for the transplants:
contrib-plugin-lifecycle-transplants
. pretty similar-looking to the previous ones. some things are done slightly differently, but I don't think I've changed any behavior.