Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds required extension points for debugger and editor plugins. #575

Closed
wants to merge 2 commits into from

Conversation

DaanVanYperen
Copy link
Collaborator

Required extension points for debugger and editors plugins.

  • New (package local) extension point for debuggers and editors. (InternalFactory). Can be set in plugins via WorldConfigurationBuilder.
  • New lifecycle phase listener for debuggers and editors (ArtemisPhaseListener). Captures pre/post init, pre/post destroy.
  • Removes final from impl specific classes to make the debug plugin work as-is. Keeps them package local.
  • Makes some small changes to managers to make it easier to replace ComponentMapper creation via ComponentManager inheritance.

The #570 Grafting mechanic is planned to replace (part of?) the InternalFactory, I'd like to retain some of the small changes and the phase listener as we probably don't want to graft world itself.

@junkdog perhaps put the grafting in this branch?

…ory to support editor and debugger plugins.

- New extension point for debuggers and editors. (`InternalFactory`)
- New lifecycle phase listener for debuggers and editors (`ArtemisPhaseListener`).
@DaanVanYperen
Copy link
Collaborator Author

DaanVanYperen commented May 18, 2019

@DaanVanYperen
Copy link
Collaborator Author

Solved using Graftt. Compromise is JVM targets only, but can live with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant