Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Meson build system support #19

Closed
wants to merge 1 commit into from
Closed

Added Meson build system support #19

wants to merge 1 commit into from

Conversation

xvitaly
Copy link

@xvitaly xvitaly commented Oct 21, 2019

Added Meson build system support.

@xvitaly
Copy link
Author

xvitaly commented Oct 21, 2019

Also path to shader file should be extracted from src/basalt.cpp#L25.

@DadSchoorse
Copy link
Owner

I do not know if I want a build system I do not use.

@xvitaly
Copy link
Author

xvitaly commented Oct 21, 2019

Now you don't use build system at all. Meson is much more better and will solve most of problems during build and install.

After merging this PR your project can be easily built and installed on any GNU/Linux distributions.

Signed-off-by: Vitaly Zaitsev <vitaly@easycoding.org>
@DadSchoorse
Copy link
Owner

I do have make and simply speaking: It works, I do not need to modify it when I am adding new cpp or glsl files and I do not know to use and write meson. Maybe in the future I will reconsider this, but for now I simply see no reason to do so.

@stephanlachnit
Copy link
Contributor

Maybe in the future I will reconsider this, but for now I simply see no reason to do so.

One reason are distribution packages. The current makefile makes this impossible, one could patch it to work but in the end once Meson is set in place, it's way easier to work with than make IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants