Remove hunk memory system from server / replace Com_Error #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was broken but now it isn't. |
DolceTriade
reviewed
Jan 28, 2019
src/engine/server/sv_init.cpp
Outdated
| svs.snapshotEntities = ( entityState_t * ) Hunk_Alloc( sizeof( entityState_t ) * svs.numSnapshotEntities, ha_pref::h_high ); | ||
| // allocate the snapshot entities | ||
| free(svs.snapshotEntities); | ||
| svs.snapshotEntities = static_cast<entityState_t*>(calloc(svs.numSnapshotEntities, sizeof(entityState_t))); |
There was a problem hiding this comment.
Please comment about the lifetime of the allocations.
There was a problem hiding this comment.
The lifetime was... it gets leaked when svs gets memset. I've changed it to use a unique_ptr and destroy svs instead of using memset.
DolceTriade
approved these changes
Jan 29, 2019
| @@ -754,14 +754,14 @@ void CL_FlushMemory() | |||
| if ( !com_sv_running->integer ) | |||
| { | |||
| // clear the whole hunk | |||
| Hunk_Clear(); | |||
| Hunk_ShutDownRandomStuffAndClear(); | |||
There was a problem hiding this comment.
heh, maybe rename it to ShutdownSubsystems() or something and don't have it call Hunk_Clear()... idk, this seems like a weird construct anyways.
There was a problem hiding this comment.
I'm hoping to do some more work on initialization and shutdown soon. In the meantime I like to give it a name that highlights the weirdness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.