-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Players who are killed by other players are safe from PvP for default 3 hours. Add client option for joining builder groups - players NOT participating in building groups will always gain the solo builder bonus point. #358
Conversation
Very good addition. |
Also i think thats the ONLY one good idea how to protect newbs from pkers and give them a chance. (NPC soldiers = suck, revenant changes = useless, 4 days jail = seriously? = kills population ) |
Unfortunately this code appears to be causing some errors at the moment, it needs a little more work. EDIT: fixed |
@skittles1 is this ready for beta? |
d963d50
to
ba8394b
Compare
75a28fb
to
d0cd57c
Compare
Note: possibly cancel the temp safe flag when the player gains a hitpoint while under its effect. |
d8ea736
to
28a8fa3
Compare
The writing for the new Temp Safe client setting was getting cropped in the German client, fixed that up and neatened up some of the other options in the preferences menu.
To hold Temp Safe toggle and other future options.
This was checking ReqSomethingAttack in the room, when AllowPlayerAttack checks that also but makes its own specific checks. This implementation should be more comprehensive in which checks are made, and allow us to have reflections on angeled characters (which is also changed in this commit).
Allow the user to choose whether or not to join a builder group. Also fixed some issues with the text commands for turning safety on/off.
Creates a new player flag, PFLAG2_TEMPSAFE. This flag is activated for innocent players under 100hp who are not faction soldiers upon taking death penalties (has to lose HP on death, i.e. 100% death penalty). The flag stays on for 3 hours by default (has setting), or until the player logs off after leaving the underworld and prevents the player from engaging in PvP.
While all players start with this flag, it can be turned off in the client by going to Game -> Preferences -> Special effects and unchecking the 'Receive temporary angel on death' option.
This pull request is part of the solution for excessive killing of new players; while it doesn't prevent them actually dying it will prevent double/triple kills of the same player in a short time frame, and will allow them freedom to retrieve their items and resume building. If three hours isn't long enough, we can increase this easily via the setting.