Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players who are killed by other players are safe from PvP for default 3 hours. Add client option for joining builder groups - players NOT participating in building groups will always gain the solo builder bonus point. #358

Merged
merged 16 commits into from
Feb 25, 2015

Conversation

skittles1
Copy link

Creates a new player flag, PFLAG2_TEMPSAFE. This flag is activated for innocent players under 100hp who are not faction soldiers upon taking death penalties (has to lose HP on death, i.e. 100% death penalty). The flag stays on for 3 hours by default (has setting), or until the player logs off after leaving the underworld and prevents the player from engaging in PvP.

While all players start with this flag, it can be turned off in the client by going to Game -> Preferences -> Special effects and unchecking the 'Receive temporary angel on death' option.

This pull request is part of the solution for excessive killing of new players; while it doesn't prevent them actually dying it will prevent double/triple kills of the same player in a short time frame, and will allow them freedom to retrieve their items and resume building. If three hours isn't long enough, we can increase this easily via the setting.

@Fike103
Copy link

Fike103 commented Feb 23, 2014

Very good addition.
I'd even buff up that timer up to 2 or even 3 hours.
As pker, i dont know why would you need to kill same guy (who just died and runs naked) other than to annoy or maybe personal KOS etc.
But dont forget to close pked person ability to attack anyone (reds and whites) while flag is up, otherwise its stupid.
Also, dont bring that flag to a halo guild scenario and shield combats. IMHO.

@Fike103
Copy link

Fike103 commented Feb 23, 2014

Also i think thats the ONLY one good idea how to protect newbs from pkers and give them a chance. (NPC soldiers = suck, revenant changes = useless, 4 days jail = seriously? = kills population )
I think it will be even better if you create some sort of flat timing calculation for Flag. 50-70hp = 6 hours 70-90 = 3 hours 90-100 = 2 hours of angel after death. This way, those true newbs who cry that they cant go past 50 hp without getting killed will get their time to farm more HPs and money than they will lose after next death.
I know, that might sound too carebear, true, but oh well... look at 103, = 100% protected sacred heaven... And if such change will zip voices about RED guild dominance and holding server hostage - thank GOD (or skittles).

@skittles1
Copy link
Author

Unfortunately this code appears to be causing some errors at the moment, it needs a little more work.

EDIT: fixed

@Daenks
Copy link
Member

Daenks commented Mar 26, 2014

@skittles1 is this ready for beta?

@skittles1 skittles1 force-pushed the tempsafe branch 3 times, most recently from d963d50 to ba8394b Compare September 23, 2014 03:35
@skittles1 skittles1 changed the title Players who die are safe from PvP for 1 hour Players who are killed by other players are safe from PvP for default 3 hours. Sep 28, 2014
@skittles1 skittles1 added this to the 1.0.2.5 milestone Sep 28, 2014
@skittles1 skittles1 force-pushed the tempsafe branch 2 times, most recently from 75a28fb to d0cd57c Compare September 28, 2014 22:15
@skittles1 skittles1 modified the milestone: 1.0.2.5 Oct 2, 2014
@skittles1
Copy link
Author

Note: possibly cancel the temp safe flag when the player gains a hitpoint while under its effect.

@skittles1 skittles1 modified the milestones: 1.0.8.4, 1.0.9.0 Jan 30, 2015
The writing for the new Temp Safe client setting was getting cropped in
the German client, fixed that up and neatened up some of the other
options in the preferences menu.
To hold Temp Safe toggle and other future options.
This was checking ReqSomethingAttack in the room, when AllowPlayerAttack
checks that also but makes its own specific checks. This implementation
should be more comprehensive in which checks are made, and allow us to
have reflections on angeled characters (which is also changed in this
commit).
Allow the user to choose whether or not to join a builder group. Also
fixed some issues with the text commands for turning safety on/off.
@skittles1 skittles1 changed the title Players who are killed by other players are safe from PvP for default 3 hours. Players who are killed by other players are safe from PvP for default 3 hours. Add client option for joining builder groups - players NOT participating in building groups will always gain the solo builder bonus point. Feb 23, 2015
@skittles1 skittles1 merged commit c78ef16 into OpenMeridian:master Feb 25, 2015
@skittles1 skittles1 mentioned this pull request Feb 25, 2015
@skittles1 skittles1 deleted the tempsafe branch March 9, 2015 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants