update README #71
Open
update README #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
内容としてはOKです 👍 コンフリクトを修正して再度プッシュしてみてください〜。コンフリクトの勉強です。 |
|
修正しましので、再度ご確認をお願いできますでしょうか。 |
DaichiSaito
reviewed
Mar 11, 2023
README.md
Outdated
Comment on lines
371
to
377
| { | ||
| kumada: { | ||
| bio: "ずっと事務職をしてましたでしたが、手に職をつけたいと思いプログラミングの勉強を始めました。現在転職活動中です。", | ||
| hobby: ["カフェ巡り", "カラオケ"], | ||
| github: "A-Kumada" | ||
| } | ||
| }, |
There was a problem hiding this comment.
コンフリクト自体は解消できていますが、kumadaさんのプロフィールを追加する場所はここで良いのかはちょいと考えものですね！
Hajimeさんという方の修正のあとにkumadaさんが修正したので、kumadaさんのプロフィールが一番下に来るのが自然な気もしました！
There was a problem hiding this comment.
対応が遅くなり申し訳ございません。
プロフィールの追加場所を修正して再度コミットしました。
お手数ですが再度ご確認をお願いできますでしょうか。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READMEの最下部に自己紹介文を追記しました。
確認よろしくお願いします。