Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update README #71

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update README #71

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b2c002
update README
Mar 10, 2023
fdc5c27
自己紹介の追加
Mar 10, 2023
170c2ab
コンフリクトの再修正
Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,13 @@ members: [
github: "Yugo-Scott"
}
},
{
kumada: {
bio: "ずっと事務職をしてましたでしたが、手に職をつけたいと思いプログラミングの勉強を始めました。現在転職活動中です。",
hobby: ["カフェ巡り", "カラオケ"],
github: "A-Kumada"
}
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コンフリクト自体は解消できていますが、kumadaさんのプロフィールを追加する場所はここで良いのかはちょいと考えものですね！

Hajimeさんという方の修正のあとにkumadaさんが修正したので、kumadaさんのプロフィールが一番下に来るのが自然な気もしました！

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応が遅くなり申し訳ございません。
プロフィールの追加場所を修正して再度コミットしました。
お手数ですが再度ご確認をお願いできますでしょうか。

{
Hajime: {
bio: "Railsの学習をしています",
Expand Down