Fix dialyzer warnings

Dalgona · Feb 4, 2020 · 9922487 · 9922487
1 parent a54c25c
commit 9922487
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 5 deletions.
diff --git a/lib/serum/build/file_processor/post_list.ex b/lib/serum/build/file_processor/post_list.ex
@@ -4,8 +4,10 @@ defmodule Serum.Build.FileProcessor.PostList do
   require Serum.Result, as: Result
   import Serum.IOProxy, only: [put_msg: 2]
   alias Serum.Error
+  alias Serum.Post
   alias Serum.PostList
   alias Serum.Project
+  alias Serum.Tag
 
   @type tag_groups() :: [{Tag.t(), [Post.t()]}]
   @type tag_counts() :: [{Tag.t(), integer()}]

diff --git a/lib/serum/fragment.ex b/lib/serum/fragment.ex
@@ -97,6 +97,7 @@ defmodule Serum.Fragment do
   defprotocol Source do
     @moduledoc false
 
+    alias Serum.Fragment
     alias Serum.Result
 
     @spec to_fragment(term()) :: Result.t(Fragment.t())

diff --git a/lib/serum/header_parser.ex b/lib/serum/header_parser.ex
@@ -85,7 +85,7 @@ defmodule Serum.HeaderParser do
     end
   end
 
-  @spec find_missing([{binary(), binary()}], [atom()], integer()) :: Result.t()
+  @spec find_missing([{binary(), binary()}], [atom()], integer()) :: Result.t({})
   defp find_missing(kv_list, required, line) do
     req_strings = required |> Enum.map(&to_string/1) |> MapSet.new()
     keys = kv_list |> Enum.map(&elem(elem(&1, 0), 0)) |> MapSet.new()

diff --git a/lib/serum/page.ex b/lib/serum/page.ex
@@ -107,6 +107,7 @@ defmodule Serum.Page do
   end
 
   defimpl Fragment.Source do
+    alias Serum.Fragment
     alias Serum.Page
     alias Serum.Result
 

diff --git a/lib/serum/plugin/loader.ex b/lib/serum/plugin/loader.ex
@@ -93,7 +93,7 @@ defmodule Serum.Plugin.Loader do
     exception -> Result.fail(Exception, [exception, __STACKTRACE__])
   end
 
-  @spec validate_elixir_version(binary(), Version.requirement()) :: Result.t()
+  @spec validate_elixir_version(binary(), Version.requirement()) :: Result.t({})
   defp validate_elixir_version(name, requirement) do
     if Version.match?(@elixir_version, requirement) do
       Result.return()
@@ -108,7 +108,7 @@ defmodule Serum.Plugin.Loader do
     end
   end
 
-  @spec validate_serum_version(binary(), Version.requirement()) :: Result.t()
+  @spec validate_serum_version(binary(), Version.requirement()) :: Result.t({})
   defp validate_serum_version(name, requirement) do
     if Version.match?(@serum_version, requirement) do
       Result.return()

diff --git a/lib/serum/post.ex b/lib/serum/post.ex
@@ -109,6 +109,7 @@ defmodule Serum.Post do
   end
 
   defimpl Fragment.Source do
+    alias Serum.Fragment
     alias Serum.Post
     alias Serum.Result
 

diff --git a/lib/serum/post_list.ex b/lib/serum/post_list.ex
@@ -149,6 +149,7 @@ defmodule Serum.PostList do
   end
 
   defimpl Fragment.Source do
+    alias Serum.Fragment
     alias Serum.PostList
     alias Serum.Result
 

diff --git a/lib/serum/project.ex b/lib/serum/project.ex
@@ -42,7 +42,7 @@ defmodule Serum.Project do
           pagination: boolean(),
           posts_per_page: pos_integer(),
           preview_length: non_neg_integer(),
-          plugins: [Plugin.plugin_spec()],
+          plugins: [Plugin.spec()],
           theme: Theme.t()
         }
 

diff --git a/lib/serum/result.ex b/lib/serum/result.ex
@@ -77,7 +77,7 @@ defmodule Serum.Result do
   defp indented(str, depth), do: [List.duplicate("  ", depth - 1), :red, "- ", :reset, str]
 
   @doc "Binds the value of the given `result` to `fun`."
-  @spec bind(Result.t(a), (a -> Result.t(b))) :: Result.t(b) when a: term(), b: term()
+  @spec bind(t(a), (a -> t(b))) :: t(b) when a: term(), b: term()
   def bind(result, fun)
   def bind({:ok, value}, fun), do: fun.(value)
   def bind({:error, %Error{}} = error, _fun), do: error