Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Show failing source codes in errors #107

Merged
merged 4 commits into from Jan 1, 2020
Merged

Conversation

Dalgona
Copy link
Owner

@Dalgona Dalgona commented Dec 29, 2019

This PR makes the implementation of Serum.Error.Format protocol for Serum.Error structs show pretty-formatted lines of failing codes, if the error struct contains valid file and line information.

Note that the displayed information may be inaccurate if the input data was manipulated by plugins.

Examples

2019-12-29-220546_521x229_scrot

2019-12-29-220626_421x131_scrot

2019-12-29-220740_513x245_scrot

@coveralls
Copy link

coveralls commented Dec 29, 2019

Coverage Status

Coverage increased (+0.08%) to 95.96% when pulling 90b9220 on wip/show-source-lines into fa52b06 on master.

@Dalgona Dalgona changed the title Show failing source codes in errors v2: Show failing source codes in errors Dec 29, 2019
@Dalgona Dalgona merged commit 937f98a into master Jan 1, 2020
@Dalgona Dalgona deleted the wip/show-source-lines branch January 1, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants