Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in pagination when viewing one entity #162

Closed
matthijsch opened this issue Jan 8, 2020 · 5 comments · Fixed by #163
Closed

Bug in pagination when viewing one entity #162

matthijsch opened this issue Jan 8, 2020 · 5 comments · Fixed by #163
Labels
bug Something isn't working
Milestone
3.3.0

Comments

@matthijsch
Copy link

Q A
DoctrineAuditBundle version 3.2.3
PHP version 7.3.13
Database MySQL

When viewing the audits for one entity which has multiple pages the pagination links are broken because the entity ID isn't passed to the paths
@matthijsch matthijsch added the bug Something isn't working label Jan 8, 2020
@DamienHarper
Copy link
Owner

@matthijsch thanks for the report. May you have a chance to test master branch?
Some fixes have been pushed since the latest release.

@DamienHarper
Copy link
Owner

@matthijsch I've just tested and the issue is still present in master branch. I'll fix this asap.

DamienHarper added a commit that referenced this issue Jan 9, 2020
@DamienHarper
Fixed pager when viewing a entity history with lots of entries (#162)
f08476b
@DamienHarper DamienHarper mentioned this issue Jan 9, 2020
Merged
DamienHarper added a commit that referenced this issue Jan 9, 2020
@DamienHarper
Fixed pager when viewing a entity history with lots of entries (#162) (…
ca367b4 
…#163)
@DamienHarper DamienHarper reopened this Jan 9, 2020
@DamienHarper
Copy link
Owner

@matthijsch I pushed a fix on master branch. May you have a chance to test master branch and provide me some feedback?

@DamienHarper
Copy link
Owner

@matthijsch I close the issue for now. Re-open it if needed

@DamienHarper DamienHarper mentioned this issue Jan 31, 2020
Closed
@DamienHarper
Copy link
Owner

@matthijsch 3.3.0 is released

@DamienHarper DamienHarper added this to the 3.3.0 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Pager fix DamienHarper/auditor-bundle
2 participants
@DamienHarper @matthijsch