Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity ID lost in pagination #165

Closed
MylesKingsnorth opened this issue Jan 31, 2020 · 4 comments
Closed

Entity ID lost in pagination #165

MylesKingsnorth opened this issue Jan 31, 2020 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone
3.3.0

Comments

@MylesKingsnorth
Copy link
Contributor

Q A
DoctrineAuditBundle version 3.2.3
PHP version 7.3.4
Database MySQL

Summary

When viewing audits for an entity with an ID, navigating using the pager fanata pagination at the bottom removes the entity ID.

Current behavior

Lose entity ID on page navigate.

How to reproduce

View audits for an entity with an ID and navigate to page 2 etc.

Expected behavior

For it to navigate to then next page while maintaining the entity ID:

From: /audit/App-Entity-MyEntity/342
To: /audit/App%5CEntity%5CMyEntity?page=2

Expected: /audit/App-Entity-MyEntity/342?page=2
@MylesKingsnorth MylesKingsnorth added the bug Something isn't working label Jan 31, 2020
@DamienHarper DamienHarper added the duplicate This issue or pull request already exists label Jan 31, 2020
@DamienHarper
Copy link
Owner

Hi @MylesKingsnorth01
It's already fixed in master branch (see #162)

@MylesKingsnorth
Copy link
Contributor Author

Hi @MylesKingsnorth01
It's already fixed in master branch (see #162)

When will the fix be tagged as a release?

@DamienHarper
Copy link
Owner

Hi @MylesKingsnorth01, I'll publish next release soon (today evening or tomorrow)

@DamienHarper
Copy link
Owner

@MylesKingsnorth01 3.3.0 is released

@DamienHarper DamienHarper added this to the 3.3.0 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
2 participants
@DamienHarper @MylesKingsnorth