Some updates! #5
Conversation
…he [browsers] section.
Added support for using the `{url}` keyword in the [browsers] section of the INI file.
Added support for full regular expressions, indicated when the key is enclosed in /'s (in the [urls] section). When using full regular expressions, the domain and path are used in the comparison; not just the domain.
Updated BrowserSelector.ini with a couple examples.
…iles. BrowserSelector will get the url from those files and open that address using the normal rules.
…hecked in BrowserSelector.ini file in the project (now embedded in the build). Added support for the `--wait` flag. Added support for opening multiple urls/files from the same command-line. Updated the README and usage.
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Include="Browser.ico" /> | ||
| </ItemGroup> | ||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | ||
| <PropertyGroup> | ||
| <PostBuildEvent>if exist "%25Bin%25\apps\$(TargetName)\$(TargetFileName)" copy /Y /V /B "$(TargetPath)" "%25Bin%25\apps\$(TargetName)\$(TargetFileName)"</PostBuildEvent> |
There was a problem hiding this comment.
I don't really understand what this is for (or why the path is "%Bin%\apps"; nothing else has an "apps" folder?)
|
Great changes, thanks! Added a question about the post build event, but otherwise I'm happy to merge this :) |
|
The build event simply copied the newly compiled executable to where I keep it on my local system. I'll remove it! Sorry about that.. :-) |
| } | ||
| else | ||
| { | ||
| if (arg.EndsWith(".url", StringComparison.InvariantCultureIgnoreCase) || arg.EndsWith(".website", StringComparison.InvariantCultureIgnoreCase)) |
There was a problem hiding this comment.
I think it'd be best to reverse the order of these, just in case anyone has a url that ends with .url, .website, etc. (sure, it's unlikely, but the other way there's no such issue; since starting with http(s)/ftp is absolutely clear).
There was a problem hiding this comment.
switched the order.. :)
Kody Brown
thewizard@wasatchwizard.com
http://wasatchwizard.com
On Thu, Feb 11, 2016 at 12:50 PM, Danny Tuppeny notifications@github.com
wrote:
In DanTup.BrowserSelector/Program.cs
#5 (comment):
{CreateSampleSettings();return;}else if (string.Equals(arg, "wait", StringComparison.InvariantCultureIgnoreCase)){waitForClose = true;}else if (string.Equals(arg, "no-wait", StringComparison.InvariantCultureIgnoreCase)){waitForClose = false;}}else{if (arg.EndsWith(".url", StringComparison.InvariantCultureIgnoreCase) || arg.EndsWith(".website", StringComparison.InvariantCultureIgnoreCase))I think it'd be best to reverse the order of these, just in case anyone
has a url that ends with .url, .website, etc. (sure, it's unlikely, but
the other way there's no such issue; since starting with http(s)/ftp is
absolutely clear).—
Reply to this email directly or view it on GitHub
https://github.com/DanTup/BrowserSelector/pull/5/files#r52656687.
|
Sorry, didn't see notification for the latest changes! |
|
@kodybrown I'm on Windows 10 now; just came to test this and it didn't work... I don't think it's related to your changes, but since you mentioned you'd tested it with Windows 10 I wondered if you had to do anything weird? I've run |
|
I don't see it either. But, to be honest, I don't know if it was ever there for me. I can't remember. Looking at my settings now it says Edge is my default browser. But, all of my file associations (set using the Open With menu) are still correct. I'll play around with it to see what I can.. |
No description provided.