Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #236

Merged
merged 4 commits into from Nov 29, 2021
Merged

Versioning #236

merged 4 commits into from Nov 29, 2021

Conversation

jacob-rosenthal
Copy link
Collaborator

Track version number in pathml/_version.py. Other places in the code where we need the version number, such as setup.py and docs/source/conf.py, we read the version number from that file. This will make it easier to track consistently. Also add a section in documentation about versioning. Also add pathml.__version__ for users.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #236 (d06c80f) into master (607c7eb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   85.30%   85.31%   +0.01%     
==========================================
  Files          25       26       +1     
  Lines        2538     2540       +2     
==========================================
+ Hits         2165     2167       +2     
  Misses        373      373              
Impacted Files Coverage Δ
pathml/__init__.py 100.00% <100.00%> (ø)
pathml/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607c7eb...d06c80f. Read the comment docs.

@ryanccarelli
Copy link
Contributor

ryanccarelli commented Nov 24, 2021

@jacobrosenthaldfci Should this be merged to master as version 1.0.4? Then we see whether the automated workflow works on 1.0.4 before merging dev and releasing 2.0.0?

@jacob-rosenthal
Copy link
Collaborator Author

Yes I think that's a great idea, however since we have already merged #231, which is backwards compatibility breaking due to the changes in the h5path format, I don't think we could do that

@ryanccarelli
Copy link
Contributor

ryanccarelli commented Nov 25, 2021

#231 is only merged to dev not master

We could merge this pr directly to master along with #235 as 1.0.4. Then merge #231 -> dev and dev -> master as 2.0.0.

@jacob-rosenthal jacob-rosenthal changed the base branch from dev to master November 29, 2021 15:04
@jacob-rosenthal jacob-rosenthal merged commit 62eaeb9 into master Nov 29, 2021
@jacob-rosenthal jacob-rosenthal deleted the versioning branch November 29, 2021 15:44
@jacob-rosenthal jacob-rosenthal mentioned this pull request Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants