fix bug when reading region from openslide backend at higher levels #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanccarelli Thoughts on how to test this? The |
Codecov Report
@@ Coverage Diff @@
## dev #242 +/- ##
==========================================
+ Coverage 84.44% 84.46% +0.01%
==========================================
Files 25 25
Lines 2405 2408 +3
==========================================
+ Hits 2031 2034 +3
Misses 374 374
Continue to review full report at Codecov.
|
|
Thanks for adding that test file @ryanccarelli , I added a test using that file (fails on dev, passes with this fix). Ready for review and merge when the CI tests pass |
ryanccarelli
approved these changes
Dec 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openslide
read_region()uses coords in the level 0 reference frame, but pathml uses coords according to each level. This was causing a bug when extracting regions and generating tiles from the openslide backend at higher levels (#240). This should fix it by scaling the coordinates before passing them to the openslide API.