Improve h5path read/write #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 84.62% 84.69% +0.06%
==========================================
Files 26 26
Lines 2432 2430 -2
==========================================
Hits 2058 2058
+ Misses 374 372 -2
Continue to review full report at Codecov.
|
jacob-rosenthal
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a read/write bug when .h5path contains a counts matrix created by our QuantifyMIF transform #159. The problem was that certain types are not supported by AnnData.
Meanwhile we now use proper scope
instead of
when adding counts.
Since read/write for .h5path breaks when reading a file edited by QuantifyMIF, I think we should add this change directly to master.