Fix env setup #265
Merged
Fix env setup #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanccarelli
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should help with environment setup problems.
spamsas a dependency (Remove spams dependency #142). Instead, if a user wants to use Vahadane stain normalization, we check if spams can be imported and throw an error if not. Also added a note in the documentation pointing to the spams website for users to install. We have faced a lot of issues with spams installation, so this should make things smoother especially since many users have no need for the one functionality which requires spamsenvironment.ymlwith a working and reproducible environment that supports deepcell (Resolving dependencies between PathML and Deepcell #259)