Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quantify mif #301

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Update quantify mif #301

merged 4 commits into from
Feb 22, 2022

Conversation

jacob-rosenthal
Copy link
Collaborator

A couple minor updates to QuantifyMIF:

  • update the functional implementation F() to not require a tile object. Instead it can be applied on any given image and mask
  • Add "label" property to counts matrix. This is useful for linking the counts matrix to the image and mask

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #301 (eec69b9) into dev (65ecf6c) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #301      +/-   ##
==========================================
- Coverage   86.93%   86.86%   -0.08%     
==========================================
  Files          26       26              
  Lines        2441     2443       +2     
==========================================
  Hits         2122     2122              
- Misses        319      321       +2     
Impacted Files Coverage Δ
pathml/preprocessing/transforms.py 88.75% <100.00%> (+0.03%) ⬆️
pathml/ml/hovernet.py 92.00% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ecf6c...eec69b9. Read the comment docs.

Copy link
Contributor

@BeeGass BeeGass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a couple of comments within transforms.py. Its well written and I dont see anything obviously wrong, I just suggested some quality of life changes. They arent pressing changes so im going to approve.

pathml/preprocessing/transforms.py Show resolved Hide resolved
pathml/preprocessing/transforms.py Show resolved Hide resolved
pathml/preprocessing/transforms.py Show resolved Hide resolved
@jacob-rosenthal jacob-rosenthal merged commit 1bcbbc2 into dev Feb 22, 2022
@jacob-rosenthal jacob-rosenthal deleted the update-quantifyMIF branch February 22, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants