Dev logging #304
Merged
Dev logging #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.0.4
…he project. Also encorporated the ability to turn 'dev mode' on/off so that logging for pathml isnt done for users using the library. Work still needs to be done in logging more of the project
…rking-install Update README.md
…ing before with how levels, filters and how they work with handlers within loguru. That has since been remedied
…are now being generated but still testing to have everything fully functional.
…d'ing into it. Also changed the notebook to include the images to download.
|
Awesome! Here are some thoughts:
|
…nt file path and remove logs that have already been saved to examples directory
…remove logs that have already been saved to examples directory
…ing, doc creation and everything else is working on my end
…r functional logging which pass. logger_wraps have been removed from all functions. An absolute file path has been set for log
… function solution.
…hich supports the custimization of a single handler
Codecov Report
@@ Coverage Diff @@
## dev #304 +/- ##
==========================================
- Coverage 86.88% 86.50% -0.39%
==========================================
Files 26 27 +1
Lines 2447 2526 +79
==========================================
+ Hits 2126 2185 +59
- Misses 321 341 +20
Continue to review full report at Codecov.
|
jacob-rosenthal
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
I think this is ready for merge.
The logging functionality is implemented and works well in my testing locally. We also added a test to make sure that it is working as expected. Also went through and added logs to the backends, as well as logging dask cluster configs when using the default cluster. Also added documentation.
We can add logs now as we go, during development/debugging
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was hoping to get feedback on logging and ideally get a checklist of things that might be doing completely wrong, missing or need to still be done. Thanks