created static homepage, created simple user model, controller, & ham… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l form new view, not yet verified sign-in or created error messages
| @@ -0,0 +1,2 @@ | |||
| module StaticHelper | |||
There was a problem hiding this comment.
Remove empty classes - you can recreate if you end up needing it
added 3 commits
May 22, 2015 11:35
| @@ -7,7 +7,14 @@ | |||
| <%= csrf_meta_tags %> | |||
| </head> | |||
| <body> | |||
| <div id="container"> | |||
| <div id="user_header"> | |||
There was a problem hiding this comment.
use dashes not underscores for HTML attributes
| @@ -0,0 +1,24 @@ | |||
| %h1 Sign Up | |||
| #new-form | |||
| = form_for(@user) do |f| | |||
There was a problem hiding this comment.
This line and all after should get indented to nest the form inside the new-form div
|
remove these unused files that were created by generators: app/assets/stylesheets/static.scss - done Convert this file to haml - done app/views/layouts/application.html.erb Move spec/features/user.rb in to a factories folder, should be spec/factories/user.rb - done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l form new view, not yet verified sign-in or created error messages