fix: publishNotReadyAddresses K8s version check #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The annotation `service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"` is deprecated since Kubernetes 1.11, following kubernetes/kubernetes#63742 The template input both fields, the annotation and the substituted field `.spec.publishNotReadyAddresses=True` but it becomes incompatible with Kubernetes <=1.10 so a check Kubernetes version resolve it put the right fields based on Kubernetes version.
DandyDeveloper
previously approved these changes
Mar 2, 2023
|
Good catch, merging although we'll need a chart bump. I'll try and do this from your branch. |
DandyDeveloper
previously approved these changes
Mar 2, 2023
DandyDeveloper
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The annotation
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"is deprecated since Kubernetes 1.11, following kubernetes/kubernetes#63742 The template input both fields, the annotation and the substituted field.spec.publishNotReadyAddresses=Truebut it becomes incompatible with Kubernetes <=1.10 so a check Kubernetes version resolve it put the right fields based on Kubernetes version.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])