Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing include <cstdint> #353

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Eisenwave
Copy link
Contributor

std::int8_t is used, but not included through #include <cstdint>.

This may work in some standard libraries because it is leaked through another header, but not in all. I have seen this cause a problem for a user in our programming community on Discord:
physics3d

@DanielChappuis
Copy link
Owner

Thanks a lot for your contribution. I will integrate this for the next release of the library.

@DanielChappuis DanielChappuis self-assigned this Aug 11, 2023
@DanielChappuis DanielChappuis added this to the Release v1.0.0 milestone Aug 11, 2023
@TheBoneJarmer
Copy link

TheBoneJarmer commented Jan 5, 2024

Hey, perhaps interesting to share. Today I tried compiling ReactPhysics3D on Windows using mingw and cmake, which failed exactly because of this error. I run the command cmake -S .. -DBUILD_SHARED_LIBS=ON -G "MinGW Makefiles followed by cmake --build . . This results in a lot of errors starting with this one. Stupidly enough, it works fine with the MSVC compiler.

Maybe an idea, depending on your scheduled release date for v1.0.0, to include this info somewhere in the readme and/or the docs until further notice?

EDIT:

I just applied this fix locally and rp3d builds fine now using above instructions. :)

@ktrace
Copy link

ktrace commented Jan 9, 2024

Keep mind, that changes in #360 too.

@DanielChappuis DanielChappuis changed the base branch from master to develop January 30, 2024 20:59
@DanielChappuis DanielChappuis merged commit 349a215 into DanielChappuis:develop Jan 30, 2024
@DanielChappuis
Copy link
Owner

Thanks for your pull request. It has been merged into the "develop" branch and will be part of the next release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants