Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Cabal-2.2.0.x #51

Closed
wants to merge 1 commit into from
Closed

Fix build with Cabal-2.2.0.x #51

wants to merge 1 commit into from

Conversation

hasufell
Copy link
Collaborator

@hasufell hasufell commented Apr 3, 2018

No description provided.

Copy link
Owner

@DanielG DanielG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've added you to the collaborators list, if you push the updated PR into a branch in this repo it will be built by the CI system. (GitLab CI unfortunately doesn't support building Github PRs yet)

@@ -1,5 +1,5 @@
name: cabal-helper
version: 0.8.0.2
version: 0.8.0.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we ought to at least do a minor version bump for new Cabal version support. I'd actually prefer to bump the version myself since its part of the release process if you don't mind.

import Distribution.Types.GenericPackageDescription
(
unFlagAssignment
)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep to the surrounding code style.

@hasufell hasufell closed this Apr 4, 2018
@hasufell
Copy link
Collaborator Author

hasufell commented Apr 4, 2018

Reopened here: #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants