This repository has been archived by the owner on Apr 25, 2020. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
5aa5d3c
commit 16e0504
Showing
9 changed files
with
8 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,7 +111,6 @@ Test-Suite spec | |
BrowseSpec | ||
CabalApiSpec | ||
CheckSpec | ||
DebugSpec | ||
FlagSpec | ||
InfoSpec | ||
LangSpec | ||
|
This file was deleted.
Oops, something went wrong.
16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this in HaRe, and it works fine for template haskell but fails for anything using the FFI
16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what "fail" means. Would you explain more concretely and give me an example?
16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use
HscNothing
, GHC is fast but does not desugar. So, we cannot get warnings such aswarn-unused-do-bind
.That's one of the reasons why I made ghc-modi.
HscInterpreted
desugars. But FFI fails as you said.Replacing
HscInterpreted
withHscAsm
works. But ".o" files are generated. I cannot find a workaround on this.16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foreign import
works with the current code butforeign export
fails, right?16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ghc-modi is shared by a project (package). I don't think
hscTarget
cannot be changed dynamically. If a HS file without FFI is targed,hscTarget
is fixed toHscInterpreted
. Then another file with FFI is targeted, we cannot changehscTarget
.16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the choice is between speed and full support, maybe have a flag we can pass in we know the project uses FFI exports and want to use ghc-modi with it, which forces the appropriate
hscTarget
. Or does this break the overall working of ghc-modi?16e0504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's continue in #205.