Add voice switcher for TTS #77
Conversation
…gine throw error), so need to handle null engine
|
|
||
| public void UpdateVoice(IList<string> voices) | ||
| { | ||
| var currentVoice = voices.Contains(CurrentVoice) ? CurrentVoice : voices.First(); |
| @@ -146,5 +148,9 @@ lang switch | |||
| _ => null | |||
| }; | |||
|
|
|||
| public string[] GetVoices() => _voices; | |||
|
|
|||
| public void SetVoice(string voice) => _voice = _voices.First(x => x.Equals(voice, StringComparison.OrdinalIgnoreCase)); | |||
There was a problem hiding this comment.
There is a bug, exception occurred when TTS with voice is selected, then user switch to another TTS. Need to set TtsConfiguration.CurrentVoice after(before) this update.
| @@ -34,6 +37,14 @@ public sealed class LanguagesSettingsViewModel : BindableBase, IAdditionalPanelC | |||
|
|
|||
| public TtsConfiguration TtsSettings { get; set; } | |||
|
|
|||
| // NOTE: wfp doesnt update combobox source for non-static propertions or properties from non-singletone class 💀, I cant find another workaround | |||
| public static ObservableCollection<string> AvailableVoices { get; } = new(); | |||
There was a problem hiding this comment.
There is some problem with VM instances... I will investigate it further and come back with update
There was a problem hiding this comment.
I got it. VM has scoped lifetime, but TtsFactory receives another VM instance (out of main scope), so UpdateVoice is called also on that wrong instance. Generally speaking, it the consequence of incorrect dependency (factory shouldn't update external component).
Let's get back to implementation with AvailableVoices in TTSConfiguration :) But with updating outside Factory (in ProcessingService). It's still not the best option though, but I have further plans for more global refactoring in that part VM <--> ProcessingService
|
Hi, sorry for such long delay with answer. Now I got back to development and left some comments |
tts engines offer various voices, this change introduces the option to choose which voice to use