Conflict with GF Coupon add on Plugin

[Pixelsmith]

Hi Danny,

Your plugin is awesome, but I've run into a conflict with it.

I'm using the Gravity Forms Coupon Add-On (https://www.gravityforms.com/add-ons/coupons/) and when I install the ACF/GF Add-On the coupon input field no longer appears in my forms. When I disable AFC/GF it appears again.

Edit: I also confirmed this bug is causing the 'Username' field to disappear.

I understand that you may not guarantee performance with optional add-ons, but I thought I'd let you know about the conflict, as it took me awhile to suss it out.

Thanks,
Adam

[nathanp]

@Pixelsmith I may have found a temporary workaround. In the /resources/Init.php file, I commented out line 10:
$this->addNotices();

This seems to have solved it for me, but I don't know if this will impact other areas of the plugin's functionality. So far it seems to be working for me.

[n8kowald]

I had a plugin conflict using Gravity Perks Nested Forms plugin: https://gravitywiz.com/documentation/gravity-forms-nested-forms

Fatal error: Uncaught Error: Call to undefined method GF_Field::get_item_label() in ...site/wp-content/plugins/gp-nested-forms/class-gp-nested-forms.php:1633

$this->addNotices() is getting and caching form meta fields too early (as soon as the plugin code is executed). Before our plugins have registered their own custom fields.
When our Gravity Form should be loading a custom field - in my case GP_Field_Nested_Form - it loads a GF_Field instead which causes issues as the custom field code is not defined.

The other thing I did was wrap two hooks (in Init.php) in an is_admin() check.

if ( is_admin() ) {
    add_action( 'acf/include_field_types', [ $this, 'addField' ] );
    add_action( 'acf/register_fields', [ $this, 'addFieldforV4' ] );
}

Here's a pull request that fixes all issues for me:
#29

[markhowellsmead]

@n8kowald @Pixelsmith @nathanp @joshlewis I have manually merged in a number of pending code amendments. Due to the age of the change requests, I would greatly appreciate it if you could install 1.2.5 from Github and let me know if the issues mentioned here are resolved. Many thanks!

[markhowellsmead]

Version 1.2.6 is now released.