Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__WD_ErrHnd added notification to __WD_Error #513

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Conversation

mlipok
Copy link
Contributor

@mlipok mlipok commented Mar 1, 2024

Pull request

Proposed changes

__WD_ErrHnd should do some notification to __WD_Error

Checklist

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

no information about COM Error reasons.

What is the new behavior?

__WD_ErrHnd added notification to __WD_Error

Influences and relationship to other functionality

none

Additional context

#512

System under test

not related

@mlipok mlipok mentioned this pull request Mar 1, 2024
9 tasks
wd_helper.au3 Outdated Show resolved Hide resolved
wd_helper.au3 Outdated Show resolved Hide resolved
wd_helper.au3 Outdated Show resolved Hide resolved
@mlipok
Copy link
Contributor Author

mlipok commented Apr 29, 2024

btw.
please also take a look on:
__WD_ErrHnd() >> $_WD_ERROR_GeneralError

I think we can not put different error number than defined in UDF.

Because it is used here:

$sMsg = $sWhere & " ==> " & $aWD_ERROR_DESC[$iErr] & " [" & $iErr & $sExtended & "]"

For this reason propse this change.

@Danp2 Danp2 merged commit 532a18f into Danp2:master Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants