Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Era' suffix; Remove '.md' from titles; Enable alternative path #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tlm2021
Copy link

@tlm2021 tlm2021 commented Jul 25, 2021

Era Display

Added the "era" data field to the span block. If specified, this will be appended to the date in the timeline display.

For example, this span would display in the timeline as "144-43-49-00 AB".

<span
    class='ob-timelines'
    data-date='144-43-49-00'
    data-era="AB"
>

Enable alternative path

Enables the path field, allowing you to specify an alternative link path. EG "My Note#My Subhead" will create an internal link directly to the "My Subhead" header in #My Note. Especially useful when using page preview, as it allows you to preview more detailed information without leaving the timeline.

Remove .md from autofilled titles

When auto-filling the title based on the filename, remove the .md from the end. More in line with how other linking/embedding is displayed through obsidian.

Dependency Update

Also updated the package.json to the latest standard for including the obsidian API. See https://github.com/obsidianmd/obsidian-api/issues/17.

## Era Display
Added the "era" data field to the span block. If specified, this will be appended to the date in the timeline display.

For example, this span would display in the timeline as "144-43-49-00 AB".
```
<span
	  class='ob-timelines'
	  data-date='144-43-49-00'
     data-era="AB"
>
```

## Remove `.md` from autofilled titles
When auto-filling the title based on the filename, remove the `.md` from the end. More in line with how other linking/embedding is displayed through obsidian.

Also updated the `package.json` to the latest standard for including the obsidian API. See https://github.com/obsidianmd/obsidian-api/issues/17.
SImply enables the `path` data field, allowing you to specify an alternative path to link to.
@tlm2021 tlm2021 changed the title Added 'Era' suffix; Remove '.md' from titles Added 'Era' suffix; Remove '.md' from titles; Enable alternative path Jul 26, 2021
@ebullient
Copy link
Collaborator

Can you rebase / resolve conflicts?

@seanlowe
Copy link

@tlm2021 I have recreated this PR on my fork of obsidian-timelines. Not sure if you still use this plugin but if you'd be willing to give it a look over to see if everything works the way you expect, I'd really appreciate it.

seanlowe added a commit to seanlowe/obsidian-timelines that referenced this pull request Jul 26, 2023
@ReconVirus
Copy link

ReconVirus commented Jul 27, 2023

@seanlowe I have recreated this PR on my fork of obsidian-timelines. Not sure if you still use this plugin but if you'd be willing to give it a look over to see if everything works the way you expect, I'd really appreciate it.

after looking over your recent updated code, i see you are still using span and div tags, might want to have a look at #58
i expand upon it to allow custom suffix based on #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants