Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filebrowser #327

Merged
merged 13 commits into from
Feb 12, 2023
Merged

Update filebrowser #327

merged 13 commits into from
Feb 12, 2023

Conversation

ClaraCrazy
Copy link
Contributor

@ClaraCrazy ClaraCrazy commented Feb 11, 2023

What's new

  • Sort alphabetically. Properly, ofc. Not the semi-broken stuff RM has
  • Fix favorites location setting
    • When no favorites are set, the browser would default to /subghz instead of /
  • Make sure we display folders before files, always
  • Add a "Internal" tab to the Browser
  • Stop loading items in weird chunks, which can cause files to be displayed out of order or not at all. This is not a performance issue unless you have over 1k files in a directory, and even then the observed time to load is ~.2 seconds which is barely noticeable

Verification

  • Open file browser
    • When no favorites are set, you are now in the root dir Browser, not Subghz
    • When favorites are set, you will see those
    • Pressing left, after being in Browser will show the new internals tab
    • Go into a folder with lots of items. (I can not confirm that this issue was as obvious on unleashed as it was elsewhere, but the issue that existed was that files would sometimes be skipped in large folders, or not sorted correctly)

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@ClaraCrazy
Copy link
Contributor Author

qFlipper_bWXAdiedOy.mp4

@Willy-JL
Copy link
Contributor

Made it show the --- name and loading icon while the list isn't done loading yet, seems like a fair solution to me :D

Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for a great job on fixing and improving that feature
After last changes all works correctly and looks good for eye :)
All tested and will be merged now

@xMasterX xMasterX merged commit e96bae8 into DarkFlippers:dev Feb 12, 2023
@RocketGod-git
Copy link

Badass, thanks! 🔥🔥🔥

@ClaraCrazy
Copy link
Contributor Author

Just devs helping each other out, as it should be.

Maybe @RogueMaster should try that once in a while too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants