Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file browser update issues #333

Merged
merged 5 commits into from Feb 12, 2023
Merged

Fix file browser update issues #333

merged 5 commits into from Feb 12, 2023

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Feb 12, 2023

What's new

  • Fixes the issues with Update filebrowser #327
  • In particular backing out of apps and folders will correctly remember and restore the previously selected item
    • I noticed that sadly after opening an app the previous history is cleared, only the last item remains selected on exit
    • Seems like this is unrelated to these PRs and is default behavior
    • This is due to the app, and saved file, selectors being used temporarily to choose a file and closed on app launch
    • The archive is unaffected since it remains open in background while app is launched
  • Also made some performance improvements by skipping view dispatcher redraws while indexing
    • Haven't properly tested the gains but it feels snappier to me
    • Mostly affects normal file browsers, the archive seems more optimized by default
  • Also updated the explanation comment with proper context, I didn't previously know the full story

Verification

  • Open apps or folders from file pickers
  • Backing out selects correct file
  • Might notice a speed-up when first loading folders

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks, now navigation in file browser works correctly

@xMasterX xMasterX merged commit 8b22952 into DarkFlippers:dev Feb 12, 2023
@RogueMaster
Copy link
Contributor

You still don't know the full story... that code you keep insulting isn't mine... it was a developer trying to improve the flipper like we all are... you shouldn't put down community works in your comments and instead encourage the growth of the project for the benefit of the community. Keep your drama out of comments...

@ClaraCrazy
Copy link
Contributor

ClaraCrazy commented Feb 12, 2023

So you once again just took code, never checked if it works properly (which it didnt), flashed it, pushed it onto the repository and gave it to people?

See @RogueMaster , gpl is one issue, and we're not gonna argue about it now because its pointless.
But dont you feel like you should give your community good code? Code that can be uninstalled, doesnt contain airtag data (doesnt matter if purposefully or not), etc etc? You cant code an entire firmware alone, nobody expects that... But you literally have a team, and more importantly, a responsibility towards your people. Theres a right way to do things, and a wrong one.

When will you learn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants