Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Fixed useMobAbility with self-targeting abilities #3359

Closed
wants to merge 2 commits into from
Closed

Fixed useMobAbility with self-targeting abilities #3359

wants to merge 2 commits into from

Conversation

ymkc
Copy link
Contributor

@ymkc ymkc commented Sep 10, 2016

Not sure it's in the best place, but it works well and fixes scripted 2hour's and other self-targeting abilities called via useMobAbilitiy

@teschnei
Copy link
Contributor

that changes the functionality of the call (previously: passing no target would let the mob use it on its current target, now it will try to use it on itself). You want to check the target type of the mobskill inside the action that gets queued and decide there whether to use GetBattleTargetID or itself

@ymkc
Copy link
Contributor Author

ymkc commented Sep 10, 2016

moved it to the queueAction call

@ymkc
Copy link
Contributor Author

ymkc commented Sep 11, 2016

@teschnei what do you think about having a distance check in there aswell?

@teschnei
Copy link
Contributor

that's not what it's for

On Sun, Sep 11, 2016 at 3:33 PM, ymkc notifications@github.com wrote:

@teschnei https://github.com/teschnei what do you think about having a
distance check in there aswell?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3359 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGI_3sE7kTAgP5Xc5sqTxAPiU2YMxRVks5qpHOogaJpZM4J5sxJ
.

@teschnei
Copy link
Contributor

ed2e95e

@teschnei teschnei closed this Sep 11, 2016
@ymkc ymkc deleted the useMobAb branch September 12, 2016 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants