Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested /* multi-line */ comments do not colour properly #1498

Closed
DanTup opened this issue Mar 2, 2019 · 3 comments
Closed

Nested /* multi-line */ comments do not colour properly #1498

DanTup opened this issue Mar 2, 2019 · 3 comments
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Mar 2, 2019

Looks like our original fix for this only covered those starting with /**, see #456 (comment) (@apaatsio).


I think this should be reopened. I'm still experiencing this.

vscode_dart_nested_comments_highlighting

Dart Code: 2.24.0
Dart VM version: 2.1.2-dev.0.0.flutter-0a7dcf17eb (Tue Feb 12 01:59:15 2019 +0000) on "linux_x64"
VSCode: 1.31.1

@DanTup DanTup added is bug in editor Relates to code editing or language features labels Mar 2, 2019
@DanTup DanTup added this to the v2.25.0 milestone Mar 2, 2019
@DanTup
Copy link
Member Author

DanTup commented Mar 11, 2019

Before/after:

Screenshot 2019-03-11 at 1 10 38 pm

@DanTup DanTup closed this as completed in 5340e19 Mar 11, 2019
@DanTup
Copy link
Member Author

DanTup commented Mar 11, 2019

@devoncarew FYI - in case you think Atom should be updated. Once again, I don't know if I've done this correctly, but it appears to have done the right thing.

I'm wondering whether we could generate this from something like this file to have it always in-sync and correct 🤔

@devoncarew
Copy link
Contributor

Thanks! I opened dart-atom/dart#1185.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

2 participants