Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorise things like SDK paths as machine-specific #1717

Closed
DanTup opened this issue May 16, 2019 · 3 comments
Closed

Categorise things like SDK paths as machine-specific #1717

DanTup opened this issue May 16, 2019 · 3 comments
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented May 16, 2019

https://code.visualstudio.com/updates/v1_34#_machinespecific-settings

Otherwise we'll get weird issues running on containers because local paths are passed in:

ERR EINVAL: invalid argument, open '/workspaces/vscode-dev-containers/containers/flutter/M:\Coding\Applications\Dart-Code-Logs\insiders.analyzer.txt': Error: EINVAL: invalid argument, open '/workspaces/vscode-dev-containers/containers/flutter/M:\Coding\Applications\Dart-Code-Logs\insiders.analyzer.txt'

@DanTup DanTup added this to the v3.1.0 milestone May 16, 2019
@DanTup
Copy link
Member Author

DanTup commented May 20, 2019

This is tricky...

Machine-specific settings can only be configured for User settings.

Many of our paths are "window" scoped, so that they can be defined within a project (eg., when you quickly switch SDKs, it's written to the current workspace). Seems like this won't work with machine settings.

We'll need to decide for each setting whether it's more important that it doesn't sync across machines, or that it can be set at the folder/workspace level.

@DanTup
Copy link
Member Author

DanTup commented May 20, 2019

I've opened microsoft/vscode#73985 to see if there's a possibility of better supporting these.

@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label May 20, 2019
@DanTup DanTup modified the milestones: v3.1.0, On Deck May 20, 2019
@DanTup
Copy link
Member Author

DanTup commented Sep 3, 2019

Insiders now has support for machine-specific overridable settings.

@DanTup DanTup modified the milestones: On Deck, v3.5.0 Sep 3, 2019
@DanTup DanTup closed this as completed in 60ff42c Sep 18, 2019
@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant