-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP Known Issues #2286
Comments
@DanTup I'm implementing the Emacs support for dart/flutter on lsp-dart so I'm checking how you did it on this extension and notice the problems above :) |
@ericdallo thanks! I've added UI Guides to the list above. CodeLens is supposed to work, though I can see it failing so I've opened #2421 - probably will be an easy fix. Thanks! |
I implemented the both features on lsp-dart, so I think it's easy to fix them on the vscode extension :) |
@ericdallo actually, the reason my code lens didn't work is that I was using an older Dart SDK that wasn't sending the outline notifications. On the most recent nightly the code lens seem to work fine. Do you know what version you were using when you saw it fail? |
Yeah, me too 😅 I was using dart dev |
Ok great, working as expected then :-) I've fixed up Flutter UI Guides and Gutter icons too. |
Nice! just a thing to keep in mind, If the next features could be implemented for LSP too, I could implement it on |
@ericdallo do you mean specific features, or just in general? Any new features being implemented are very likely to be added to LSP too (some may even only be implemented in LSP) as I'd like to switch Dart-Code over to LSP by default (without losing any significant functionality). Some of the things mentioned above (like |
Nice, good to know! |
I just tested the lsp preview in vscode and dart-lang/sdk#41195 also happens in vscode. |
Also, the line length setting for the formatter is ignored |
Do you have steps to repro this in VS Code? I just tried following essentially the same instructions, but it didn't seem to happen. If you can grab an analysis server log while doing so, that may help too.
Thanks! Got a fix for this at https://dart-review.googlesource.com/c/sdk/+/154008. |
Noted at Dart-Code/Dart-Code#2286 (comment). Change-Id: If45bede84a0a4414a16d1809a1aa0f81d18cebfb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154008 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
@Kavantix I reproduced this with Dart 2.8.2 but couldn't reproduce on the current code to try and debug. Could you temporarily try with the latest nightly SDK from http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/ to see if it still happens for you there?
That doesn't sound right - though VS Code sometimes doesn't update files that are modified correctly unless you close/re-open them - could it be that? Also - can you check you used |
@DanTup I am using latest beta version of DartCode in LSP mode. How can I set custom line length? |
@DanTup Also happens with the last version: It did however now write some info to the log file Btw I was checking the log file using |
This fix is in the server, so you need an updated Dart SDK (such as a nightly from http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/). It should then use the same
Thanks - I also managed to hit this again yesterday in the nightly, so it is still there. I'll do some more digging, thanks! |
@DanTup Sorry, I don't know whether I should ask that here. But, Flutter doesn't allow custom Dart SDKs right? If yes, then I would wait for it. (BTW, I am on Flutter Dev channel) |
@RaviKavaiya correct - for Flutter you need to use the SDK it provides. When you run |
@Kavantix I got to the bottom of the issue - I've got a fix out for review at https://dart-review.googlesource.com/c/sdk/+/154960/. Thanks! |
Bug: Dart-Code/Dart-Code#2286 (comment) Change-Id: Ibb49a3b244ca40da5018fd705adffdbe6e0ce880 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154960 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
@DanTup I can confirm that the fix works, Thanks a lot this will save me quite some headaches using the LSP in vim :) |
@Kavantix excellent, thanks for confirming! |
Most of the issue here are resolved. There are a few outstanding which have their own issues (which I've linked in the description above), which I'm hoping to address fairly soon so that LSP can become the default. If you encounter any other issues not listed, please file new specific issues. Thanks! |
When running in LSP mode, the following things are known not to work (or function differently to non-LSP):
Running "Dart: Sort Members" command failsWidget UI Guides don't workSupport Flutter UI Guides in LSP #2425Gutter Icons don't workSupport Gutter Icons in LSP #2426Thewontfixdart.doNotFormat
setting used to exclude files/folders from auto-formatting does not workTheSupport the "dart.analysisExcludedFolders" setting in LSP #2680dart.analysisExcludedFolders
setting does not exclude folders from analysisThedart.enableSdkFormatter
setting does not unregister the formatterAnalysis server plugins do not workFind implementations only works on the method namewontfixRename does not work on thewontfiximport
orclass
keywordsRefactor: Extract method is not availableRefactor: Extract widget is not availableThe text was updated successfully, but these errors were encountered: