Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate code actions appear in quick-fix when two diagnostics have similar fixes on the same line #2960

Closed
DanTup opened this issue Nov 17, 2020 · 1 comment
Closed

Duplicate code actions appear in quick-fix when two diagnostics have similar fixes on the same line #2960

DanTup opened this issue Nov 17, 2020 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Milestone
v3.17.0

Comments

@DanTup
Copy link
Member

DanTup commented Nov 17, 2020

We already de-dupe actions that have the same fix (eg. multiple "Import library foo" actions), but those that have their own fixes still show up multiple times.

Nov-17-2020 10-45-37

When the titles are the same, we should pick the one closest to the caret (or in the case of a range, the start of the range).
@DanTup DanTup added is bug in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server labels Nov 17, 2020
@DanTup DanTup added this to the v3.17.0 milestone Nov 17, 2020
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 19, 2020
@DanTup
[Analyzer] Don't show duplicate LSP code actions on same line
732305f 
Fixes Dart-Code/Dart-Code#2960.

Change-Id: I63361728e80c7db843db9e2b31e76eae78f85400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172562
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Nov 19, 2020

Fixed in dart-lang/sdk@732305f.

@DanTup DanTup closed this as completed Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Projects
None yet
Milestone
v3.17.0
Development

No branches or pull requests
1 participant
@DanTup