Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developing in the Dart SDK repo checked out as a git worktree triggers unwanted "pub" runs #4501

Closed
DanTup opened this issue Apr 20, 2023 · 1 comment
Closed

Developing in the Dart SDK repo checked out as a git worktree triggers unwanted "pub" runs #4501

DanTup opened this issue Apr 20, 2023 · 1 comment
Labels
is bug
Milestone
v3.64.0

Comments

@DanTup
Copy link
Member

DanTup commented Apr 20, 2023

See dart-lang/sdk#52067 (comment).

We're finding the git root by looking only for files, but in this case .git is a file.
@DanTup DanTup added the is bug label Apr 20, 2023
@DanTup DanTup added this to the v3.64.0 milestone Apr 20, 2023
@DanTup DanTup mentioned this issue Apr 20, 2023
Closed
@DanTup
Copy link
Member Author

DanTup commented Apr 20, 2023

Should we change this check to only look for DEPS? See dart-lang/sdk#52067 (comment)

@stereotype441 stereotype441 mentioned this issue Apr 21, 2023
Open
@DanTup DanTup closed this as completed in f566c99 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is bug
Projects
None yet
Milestone
v3.64.0
Development

No branches or pull requests
1 participant
@DanTup