Debug Console location metadata doesn't appear when not running in debug mode

[osaxma]

Describe the bug

Issue 1: The URI on the right hand side of the Debug Console doesn't work (screenshot 1)
Issue 2: The URIs printed in the Debug Console and Test Results work but the line number isn't a part of the URI -- i.e. cannot jump to the line using the URIs (screen shot 1 & 2)

Please see the screenshots below:

1- Screenshot 1

2- Screenshot 2

To Reproduce
Steps to reproduce the behavior:

1. create test/some_test.dart
2. add the following snippet:

import 'package:test/test.dart';
void main() {

    void failure() => throw UnimplementedError();
    test('fail', () {
      failure();
    });
}

Please complete the following information:

• Operating System and version: 12.6 (21G115)
• VS Code version: 1.82.2
• Dart extension version: v3.74.0
• Dart/Flutter SDK version: Dart SDK version: 3.1.2 (stable) (Tue Sep 12 16:26:23 2023 +0000) on "macos_x64"

sorry if this is already reported or should be filed elsewhere -- please let me know

[DanTup]

The links on the right not working looks like the issue in #4573 which should be fixed in the latest builds/betas (works for me on a 3.2 build).

I think the second one is because VS Code doesn't handle links very well in Test Results (maybe slightly related to microsoft/vscode#150702, as the Peek Error window and Test Results both use terminals). The reason you can click on it when you hold Ctrl, is that that basically lets you click anything (for ex. UnimplementedError gets underlined when you hold Ctrl and hover it) and will try to open it. I think once they implement link providers there, we can contribute scanning for paths/lines in there.

Edit: Yeah, I verified our TerminalLinkProvider does not currently fire for that Test Results pane so we can't influence the links there yet.

[osaxma]

The links on the right not working looks like the issue in #4573 which should be fixed in the latest builds/betas (works for me on a 3.2 build).

I am mainly on stable now... so I will just wait until it gets there...

Feel free to close the issue unless you'd like to track it

Cheers

[DanTup]

Will close as I don't think there's anything to do, but do shout if you see issues after you get the fix for #4573.

If microsoft/vscode#157500 gets implemented in VS Code, I'll add support for the other part - though it's probably not worth tracking in an open issue until that happens since sometimes things don't 🙃

[osaxma]

Hi @DanTup

I just tried at a recent main (96ae2c3) in my local build and I noticed that it works for Debug

... But the right-side links are not available anymore when I do Run without Debugging which seemes like a regression ..

[DanTup]

Hmm, on the surface that doesn't feel right. I would expect we might fail to map package: URIs when not running under the debugger (because we use the debugger to map them), but it doesn't seem like these would be packages.

I presume you're testing with a simple Dart test, no Flutter involved?

[osaxma]

I presume you're testing with a simple Dart test, no Flutter involved?

Yeah, just Dart.

The screenshot is from a scratch project where the test file is exactly as the sample code in the original issue.

[DanTup]

Thanks - I can repro and have found the issue. Working on a fix :-)

https://dart-review.googlesource.com/c/sdk/+/330140

[DanTup]

Fixed by dart-lang/sdk@b706bfc. The fix ships in the SDK debug adapter, so it'll show up in a future SDK release.