Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for experimentalMacroSupport and gate on SDK version #5105

Closed
DanTup opened this issue May 12, 2024 · 0 comments
Closed

Remove the need for experimentalMacroSupport and gate on SDK version #5105

DanTup opened this issue May 12, 2024 · 0 comments

Comments

@DanTup
Copy link
Member

DanTup commented May 12, 2024

The dart.experimentalMacroSupport setting was used to enable new APIs to get generated code from the server into VS Code. There's been enough testing that this flag is probably unnecessary now, however we should gate enabling these new APIs on a suitable version number where this API support is more stable/complete (perhaps 3.5.0-0, since 3.5 is what current bleeding-edge builds are).

@DanTup DanTup added this to the v3.88.1 milestone May 12, 2024
@DanTup DanTup closed this as completed in 619a076 May 13, 2024
DanTup added a commit that referenced this issue May 13, 2024
This will allow macros to be controlled just by the SDK experiment flags and not require an additional VS Code setting. It will only enable for >= 3.5.0-0 (current bleeding edge) since that's the only place macros work well enough to try out.

Fixes #5105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant