Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Outline #605

Closed
20 of 24 tasks
DanTup opened this issue Feb 21, 2018 · 4 comments · Fixed by #961
Closed
20 of 24 tasks

Flutter Outline #605

DanTup opened this issue Feb 21, 2018 · 4 comments · Fixed by #961
Labels
in flutter Relates to running Flutter apps is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 21, 2018

This case is to implement something similar to the Flutter Outline view from IntelliJ (note: this is still heavily in dev, using an experimental API and subject to change!)

flutter outline in intellij

@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps labels Feb 21, 2018
@DanTup DanTup added this to the v3.0.0 milestone Feb 21, 2018
@DanTup DanTup changed the title Flutter outline view Flutter Preview Feb 22, 2018
@DanTup DanTup changed the title Flutter Preview Flutter Outline Feb 27, 2018
@chances
Copy link

chances commented Feb 28, 2018

What does this issue cover?

@DanTup DanTup modified the milestones: v2.10.0, v2.11.0 Mar 4, 2018
@DanTup
Copy link
Member Author

DanTup commented Mar 5, 2018

Apologies, I thought I'd replied to this! This case is to attempt to add something like the Flutter Outline view that was added to IntelliJ recently:

https://groups.google.com/forum/#!topic/flutter-dev/lKtTQ-45kc4

DanTup added a commit that referenced this issue Mar 5, 2018
DanTup added a commit that referenced this issue Mar 5, 2018
DanTup added a commit that referenced this issue Mar 5, 2018
We can't control formatting of text so the labels look long with the
attributes in them (which is what IntelliJ does).

See #605.
DanTup added a commit that referenced this issue Mar 6, 2018
Currently doesn't work because we're missing the commands
(microsoft/vscode#45124).

See #605.
DanTup added a commit that referenced this issue Mar 7, 2018
DanTup added a commit that referenced this issue Mar 7, 2018
DanTup added a commit that referenced this issue Mar 7, 2018
DanTup added a commit that referenced this issue Mar 7, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
Some items still outstanding (require Code tweaks).

See #605.
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
We can't control formatting of text so the labels look long with the
attributes in them (which is what IntelliJ does).

See #605.
DanTup added a commit that referenced this issue Jun 6, 2018
Currently doesn't work because we're missing the commands
(microsoft/vscode#45124).

See #605.
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
Some items still outstanding (require Code tweaks).

See #605.
DanTup added a commit that referenced this issue Jun 6, 2018
DanTup added a commit that referenced this issue Jun 6, 2018
@sionicion
Copy link

What's the current status on this? Is there a way to test the current state of it?

@DanTup
Copy link
Member Author

DanTup commented May 27, 2019

There's been no real progress on this. Periodically I come back to it, rebase the changes I have and test them out, but each time I'm disappointed with the behaviour. There are two possible implementations but both of them have significant issues that aren't resolved.

  1. A completely custom tree - this doesn't work well becaues custom trees have lots of quirks and missing features compared to the built-in Outline view
  2. Use the built-in Outline view with a setting to enable the Flutter parts - this doesn't work well because injecting the extra nodes messes up the symbol list (which is the same issue as Symbol list unexpectedly contains things like <function> microsoft/vscode#51332)

I think the second option is best, but unless Code gets a fix for the issue above, it's not really a good option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants